Refactor TestHttp.testHttpclient to avoid the Exception Suppression#6733
Refactor TestHttp.testHttpclient to avoid the Exception Suppression#6733yadvr merged 2 commits intoapache:mainfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
@Codegass is this test actually run? as it is in a package called |
Codecov Report
@@ Coverage Diff @@
## main #6733 +/- ##
=========================================
Coverage 10.41% 10.41%
- Complexity 6685 6686 +1
=========================================
Files 2454 2454
Lines 242975 242975
Branches 38036 38036
=========================================
+ Hits 25305 25307 +2
+ Misses 214508 214507 -1
+ Partials 3162 3161 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@DaanHoogland Hi Daan, Thank you for the notice. You are correct, I just run the overall test suite and missed the single test of itself. Please allow me to dig a little bit. |
|
@blueorangutan package |
|
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
On second look, the changes are in (unit) test code and Travis has passed. |
|
Awesome work, congrats on your first merged pull request! |
4 participants
Description
FIX #6673
This PR removes the catch block with the
e.printStackTrace(), which suppressed the Exceptions to be thrown in the CI\CD's final report.These catch blocks will only print the the Exception information and will not raise any failure in the testing process. This behavior will lead the developer harder to notice the issue in the CI\CD reports.
I suggest removing the try-catch structure and adding some additional assertion(if possible). This will improve the readability of the test cases, and avoid missing the test failure. Even if the exception does not raise by the component that we are testing here, we can still know that we need to fix the outside conditions first to make sure the test case running under stable and consistent conditions.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
Local cluster environment (KVM, UBUNTU 18.04) runs the test suite.